AST: Return analysis errors through DiagnosticManager - #418
Merged
KyrylR merged 1 commit intoSep 20, 2026
Merged
Conversation
KyrylR
reviewed
Sep 18, 2026
LesterEvSe
force-pushed
the
feat/collect-multi-errors
branch
2 times, most recently
from
September 18, 2026 14:16
5b8c09d to
ffe3b65
Compare
LesterEvSe
force-pushed
the
feat/collect-multi-errors
branch
from
September 18, 2026 14:20
ffe3b65 to
1f279a4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares the AST phase for reporting multiple errors.
Program::analyzenow takes&mut DiagnosticManagerand returnsOption<Self>instead ofResult<Self, Diagnostic>. Behaviour does not change: analysis still stops at the first error.Next steps
Follow-up PRs will extend analysis from one error to many, one level at a time:
Each step reports only independent errors, so it does not need poisoning to prevent cascading errors. Poisoning will come later, for the cases where analysis would otherwise stop, such as a broken declared type.