flake: fix packaging — use v2.3 release from this repo, not stale bestdownload v1.5 - #30
Merged
Merged
Conversation
Contributor
|
Do a |
cookieidea
force-pushed
the
fix-flake-v2.3
branch
from
September 13, 2026 22:42
9d2b206 to
0bb5703
Compare
Contributor
Author
|
How should I handle the hash verification? |
Contributor
Author
|
The next release will still require manually updating the hash. |
Contributor
|
For the hash, just calculate it from the new v2.3 tarball with |
Derive src URL and sourceRoot from `version` via a recursive attrset, so bumping only touches `version` (the src hash still has to be pinned manually, as Nix fixed-output derivations require).
Contributor
Author
|
I guess this is the only way. |
Contributor
Author
|
The version number still needs to be updated manually, but the download URL doesn't need to be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the BestClient version on Nix