Convert floating-point types from double to single precision - #62
Open
certik wants to merge 3 commits into
Open
Conversation
Replace double precision with default real and D-exponent literals with E-exponent literals so Formal can run on hardware without f64 support, such as Apple GPU. Relax test tolerances and use coarser 2x grids for order-of-accuracy checks dominated by roundoff.
certik
marked this pull request as draft
August 29, 2026 20:37
Linux flang and lfortran report slightly different observed orders and roundoff than macOS. Widen the 4th-order gradient and laplacian convergence windows and the 2D vector-scalar product absolute tolerance so the suite passes across platforms.
Contributor
rouson
marked this pull request as ready for review
August 31, 2026 23:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace double precision with default real and D-exponent literals with E-exponent literals so Formal can run on hardware without f64 support, such as Apple GPU. Relax test tolerances and use coarser 2x grids for order-of-accuracy checks dominated by roundoff.
All tests pass with: