Repository navigation
Release v9.3.2 - #209
Release v9.3.2#209
Conversation
Release v9.3.1 (merge back into develop)
…owsers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h-typeerror-as-network fix(transport): classify fetch TypeErrors as network errors
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The sole behavior change is small, correctly implemented, and fully covered by updated tests, and the version/CHANGELOG match the standard scripts/release.sh output with no discrepancies.
Review effort: Balanced
Findings: None
What changed in this PR
This is the release PR for @behindthemusictree/app-kit v9.3.2 (9.3.1 → 9.3.2), targeting main from a release/* branch per the repo's Gitflow. It bundles the version bump and CHANGELOG cut together with the single bugfix it ships: simplifying how createNetworkOrBackendError classifies TypeErrors thrown by fetch. Previously, backend TypeErrors like "Failed to fetch"/"Network request failed" were misattributed as BACKEND_UNAVAILABLE (showing an internal-error popup), and Safari/Firefox variants ("Load failed", "NetworkError when attempting to fetch resource.") fell through to BACKEND_INTERNAL_ERROR/NETWORK_UNKNOWN. Now any non-timeout fetch TypeError consistently maps to NETWORK_FAILED_TO_FETCH, since a dropped client connection can't be distinguished from a down backend.
Changes:
- Collapse the per-message
TypeErrorbranches into: timeouts keep their timeout codes, everything else returnsNETWORK_FAILED_TO_FETCH. - Update tests to assert the unified mapping across Chrome/Safari/Firefox/React Native messages and unknown messages, for both backend and non-backend URLs.
- Bump version to 9.3.2 and add the matching
CHANGELOG.mdentry.
| File | Description |
|---|---|
packages/app-kit/src/transport/app-errors/app-error-factory.ts |
Simplifies TypeError handling so non-timeout fetch errors uniformly map to NETWORK_FAILED_TO_FETCH |
packages/app-kit/src/transport/app-errors/app-error-factory.test.ts |
Replaces old per-message assertions with parameterized coverage of the new unified mapping |
packages/app-kit/package.json |
Version bump 9.3.1 → 9.3.2 |
CHANGELOG.md |
Adds the 9.3.2 Fixed entry describing the transport behavior change |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release v9.3.2 (9.3.1 -> 9.3.2). After this merges, run
pnpm tag-releaseonmainto tag and trigger the publish workflow, then merge the companion PR intodevelop.