Skip to content

Release v9.3.2 - #209

Merged
Andreas-Garcia merged 6 commits into
mainfrom
release/9.3.2
Oct 6, 2026
Merged

Andreas-Garcia merged 6 commits into
mainfrom
release/9.3.2

Conversation

@Andreas-Garcia

Copy link
Copy Markdown
Member

Release v9.3.2 (9.3.1 -> 9.3.2). After this merges, run pnpm tag-release on main to tag and trigger the publish workflow, then merge the companion PR into develop.

Andreas-Garcia and others added 5 commits October 6, 2026 13:55
Release v9.3.1 (merge back into develop)
…owsers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h-typeerror-as-network

fix(transport): classify fetch TypeErrors as network errors
Copilot AI balanced review requested due to automatic review settings October 6, 2026 20:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The sole behavior change is small, correctly implemented, and fully covered by updated tests, and the version/CHANGELOG match the standard scripts/release.sh output with no discrepancies.

Review effort: Balanced
Findings: None

What changed in this PR

This is the release PR for @behindthemusictree/app-kit v9.3.2 (9.3.1 → 9.3.2), targeting main from a release/* branch per the repo's Gitflow. It bundles the version bump and CHANGELOG cut together with the single bugfix it ships: simplifying how createNetworkOrBackendError classifies TypeErrors thrown by fetch. Previously, backend TypeErrors like "Failed to fetch"/"Network request failed" were misattributed as BACKEND_UNAVAILABLE (showing an internal-error popup), and Safari/Firefox variants ("Load failed", "NetworkError when attempting to fetch resource.") fell through to BACKEND_INTERNAL_ERROR/NETWORK_UNKNOWN. Now any non-timeout fetch TypeError consistently maps to NETWORK_FAILED_TO_FETCH, since a dropped client connection can't be distinguished from a down backend.

Changes:

  • Collapse the per-message TypeError branches into: timeouts keep their timeout codes, everything else returns NETWORK_FAILED_TO_FETCH.
  • Update tests to assert the unified mapping across Chrome/Safari/Firefox/React Native messages and unknown messages, for both backend and non-backend URLs.
  • Bump version to 9.3.2 and add the matching CHANGELOG.md entry.
File Description
packages/​app-kit/​src/​transport/​app-errors/​app-error-factory.ts Simplifies TypeError handling so non-timeout fetch errors uniformly map to NETWORK_FAILED_TO_FETCH
packages/​app-kit/​src/​transport/​app-errors/​app-error-factory.test.ts Replaces old per-message assertions with parameterized coverage of the new unified mapping
packages/​app-kit/​package.json Version bump 9.3.1 → 9.3.2
CHANGELOG.md Adds the 9.3.2 Fixed entry describing the transport behavior change

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Andreas-Garcia
Andreas-Garcia merged commit 5f74a23 into main Oct 6, 2026
5 checks passed
@Andreas-Garcia
Andreas-Garcia deleted the release/9.3.2 branch October 7, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants