Repository navigation
Conversation
A split has no receiver, so IsSelfTx was never set for it: its status read "sent" instead of "sent to own address", and clients showed the split amount as spent. SimpleTransaction::IsSelfTx() already treats a tx without a receiver as a self tx; its creator now records that.
profinch
force-pushed
the
wallet-split-self-tx
branch
from
October 24, 2026 23:05
a1d2d3e to
bbab51d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A split has no receiver, so
IsSelfTxwas never set for it: its status read "sent" instead of "sent to own address", and clients showed the split amount as spent.SimpleTransaction::IsSelfTx()already treats a tx without a receiver as a self tx; its creator now records that.Test:
wallet_test.cppchecksm_selfTxon the split tx.Patch authored by @Maxnflaxl, opened on their behalf (account suspended).
🤖 Generated with Claude Code