Repository navigation
fix(composer): allow composer/installers v2 - #12
Merged
Merged
Conversation
The `^1.0` constraint on composer/installers pins consuming projects (wp-skeleton among others) to installers 1.x, which emits PHP 8.4 implicit-nullable deprecation notices on every Composer command. Accept `^1.0 || ^2.0` so projects can resolve installers 2.x. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The workflow still targeted PHP 7.4, which grumphp-shim ^2.7 cannot install on, and still ran `composer psalm` although Psalm was removed from the project. Move the matrix to supported PHP versions, drop the Psalm step and its orphan Composer script, and update actions/checkout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
With the Dealerdirect installer disallowed, `installed_paths` is never set on a clean install and `composer cs` aborts with "Referenced sniff WordPress-Extra does not exist". Allow the plugin, as the other agency projects do, and move actions/checkout to v5. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Projects built on
beapi/wp-skeletoncannot resolvecomposer/installers2.x because this package requires^1.0. Installers 1.12 emits PHP 8.4 deprecation notices (implicit nullable parameter inInstaller::__construct()) on every Composer command.Changes
composer.json:composer/installersconstraint relaxed to^1.0 || ^2.0.1.0.3so a release tag can follow.quality.ymlmatrix moved from PHP 7.4 to 8.2 / 8.3 / 8.4 (grumphp-shim ^2.7needs PHP 8.1+), Psalm step removed (Psalm left the project in 1.0.2),actions/checkoutbumped to v5.allow-plugins: Dealerdirect PHPCS installer set totrue, otherwise WordPress standards are never registered on a clean install andcomposer csaborts.composer psalmscript removed.After merge
Tag
1.0.3onmasterso*@stableconsumers pick it up. Same fix pending onbea-disable-xmlrpc.🤖 Generated with Claude Code