Repository navigation
refactor(ui): migrate to Base UI and simplify effects - #5
Merged
Merged
Conversation
Pin @base-ui/react 1.9.0 as the headless component foundation for the incremental UI migration.
Use solid panel and elevated surfaces, remove backdrop-filter tokens and fallbacks, and add a root stacking context for future portals.
Replace the custom modal focus trap, escape and overlay handling with Base UI Dialog and AlertDialog while preserving visual classes and animation modes.
Use Base UI context menus, menu items, toast and popover primitives for SFTP/terminal context menus, notifications and the transfer center.
Replace Radix Select with Base UI Select, use Base UI field primitives in host and settings forms, and split SettingsModal into section components.
Drop the retired Radix dependency, remove stale selectors, define the missing surface token, and update test setup comments.
Keep parallel migration worktrees out of repository-wide ESLint and Prettier runs.
Fail the Linux job when any expected package is missing and assert the RPM and pacman artifacts in the CI structure test.
Retry hdiutil create after detaching a stale NodeShell mount, and cover the retry in the CI structure test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@base-ui/react@1.9.0SettingsModalinto focused section componentsbackdrop-filter/ glass surfaces and animation of heavy shadows--bg-surfacetoken and ignore local worktrees in lint/formatValidation
npm run typechecknpm test(25 files / 299 tests)npm run lint(0 errors)npm run build:wailswails build -tags webkit2_41 -platform linux/amd64Notes
This is stacked on the Eino migration branch. Terminal (xterm) and CodeMirror stay as dedicated components; session tabs remain custom to avoid unmounting terminal instances.