Updating our homebrew casks to use "postflight_steps", instead of postflight - #10095
Open
Richard Park (richardpark-msft) wants to merge 2 commits into
Open
Richard Park (richardpark-msft) wants to merge 2 commits into
Richard Park (richardpark-msft) wants to merge 2 commits into
Conversation
added 2 commits
September 17, 2026 16:34
…eps`, now that `postflight` has been deprecated. Also, added in a test target in our magefile (homebrew:check) so you can validate your freshly edited Cask using Linux homebrew, in case you're not on a Mac :)
…nts, and trying to make it clearer.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 24 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Richard Park (richardpark-msft)
September 18, 2026 00:08
View session
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical and moderate issues remain in Homebrew validation and Mage command integration.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Lite.
Open (2)
What changed in this PR
Updates Homebrew casks to use declarative postflight_steps and adds containerized validation tooling.
Changes:
- Replaces deprecated
postflightblocks. - Adds stable and daily cask installation checks.
- Adds Mage integration and container-runtime test updates.
| File | Reviewed changes |
|---|---|
eng/templates/brew.cask.template |
Updates stable cask postflight handling. |
eng/templates/brew.cask.daily.template |
Updates daily cask postflight handling. |
eng/scripts/test-homebrew-casks.sh |
Renders and validates stable and daily cask installations. |
cli/azd/magefile.go |
Adds Homebrew testing support and runtime detection. |
cli/azd/magefile_test.go |
Updates runtime detection tests. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Richard Park (richardpark-msft)
enabled auto-merge (squash)
September 18, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew has a new, declarative way, of handling postflight now, so we're switching over.
This PR also adds in a handy little tester (go tool mage homebrew:test), which will let you take your locally modified cask templates and use them to install the latest azd, in a brew container.
Fixes #10046