[Copilot]

Summary

Fixes #749.

The original implementation needed correction: postfix increments caused the retry loops to exit immediately under set -e, and ARM provisioning success did not establish Grafana API readiness. Data-source setup could also fail before dashboard retries ran.

• Merge current main to resolve conflicts and preserve dashboard datasource/cluster defaults.
• Probe the Grafana data-plane API using az grafana data-source list before configuring data sources or dashboards: 30 attempts, 30 seconds between attempts.
• Retry data-source creation and dashboard imports three times with 10-second delays.
• Preserve CLI errors and exit unsuccessfully when retries are exhausted; do not report partial setup as success.
• Use the selected Grafana subscription consistently and clean up temporary dashboard definitions on success or failure.
• Regenerate the deployment bundle and add mocked shell regression tests to CI.

Validation

• Bash syntax checks passed.
• Six regression scenarios passed against both source setup and the extracted deployment bundle: existing instance, newly provisioned instance, readiness exhaustion, data-source exhaustion, dashboard exhaustion, and immediate success.
• Tests verify exact retry counts/delays, visible CLI errors, failure exit statuses, dashboard defaults, all five imports, and temporary-file cleanup.
• make k8s-bundle completed successfully; bundled setup/helper match their sources.
• Changes pass whitespace validation against current main.
• No live Azure deployment was performed; full Go CI remains separate from the targeted shell validation.

[Matt Tucker (matucker-msft)]

Reviewed against #749 and corrected the original retry-loop and readiness gaps in commit 666946f. The setup now probes the Grafana data-plane API before configuration, retries data-source/dashboard creation with bounded delays, preserves dashboard defaults from main, surfaces exhaustion as failure, and includes automated regression coverage. All six mocked scenarios passed against both source and extracted bundle; bundle generation and bash syntax checks passed. Approved on that basis; no live Azure deployment was performed.

[Copilot]

🟢 Approval recommended

No blocking issues were identified in the retry logic, failure handling, cleanup, regression coverage, or bundle consistency.

No open issues 🎉

What changed in this PR

Addresses #749 by waiting for Azure Managed Grafana’s API to become available before configuring ADX-Mon data sources and dashboards.

Changes:

• Adds bounded readiness checks and retries for data-source creation and dashboard imports.
• Handles retry exhaustion, uses the selected Grafana subscription, and cleans up temporary dashboard files.
• Adds mocked shell regression tests to CI, documents retry behavior, and regenerates the deployment bundle.

File	Description
docs/​quick-start.md	Documents readiness checks, retries, and failure behavior.
build/​scripts/​test-grafana-setup.sh	Adds regression scenarios for retries, failures, defaults, and cleanup.
build/​k8s/​setup.sh	Integrates readiness checks, retries, subscription selection, and cleanup.
build/​k8s/​grafana.sh	Adds a shared bounded retry helper.
build/​k8s/​bundle.sh	Includes updated setup logic and the retry helper.
.github/​workflows/​build-pr.yaml	Runs Grafana setup regression tests in CI.

_{Review effort: Balanced}