fix(web): restore import/order after the weekly-rotation rename - #14583
Merged
Conversation
The Weekly Rotation rename (#14582) renamed `components/discover-weekly` to `components/weekly-rotation` in place, which moved it past its neighbours alphabetically and broke `import/order` in three files. Lint failed on main, so the Web Build, Deploy, Desktop and Production Release Gate jobs all skipped — nothing from that run could ship. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Web Lint & Stylelintfails on main at 02ee302, which takes the whole pipeline down with it — Web Build, Web Deploy, all three Desktop builds and the Production Release Gate every one skipped. Nothing from that run can ship.Cause
#14582 renamed
components/discover-weekly→components/weekly-rotationin place.dsorts beforeheader/lineup/nav/page/tabs;wsorts after all of them, so the import line that was correctly placed under the old name is now out of order under the new one. Three call sites were affected.Fix
Moved each
WeeklyRotationBannerimport to its new alphabetical position. Import-only change — no runtime difference, and--fixproduces exactly this.pages/feed-page/components/desktop/FeedPageContent.tsxpages/search-explore-page/components/desktop/SearchExplorePage.tsxpages/search-explore-page/components/mobile/SearchExplorePage.tsxTest plan
components/import blocks verified in sorted orderNote
This is currently what blocks the production web deploy. The Production gate has five runs waiting back to Aug 24, including the 12/31/69 album-date fix (#14579); main HEAD couldn't join them because of this lint failure.
🤖 Generated with Claude Code