Skip to content

fix(web): restore import/order after the weekly-rotation rename - #14583

Merged
dylanjeffers merged 1 commit into
mainfrom
fix/weekly-rotation-import-order
Sep 1, 2026
Merged

fix(web): restore import/order after the weekly-rotation rename#14583
dylanjeffers merged 1 commit into
mainfrom
fix/weekly-rotation-import-order

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Problem

Web Lint & Stylelint fails on main at 02ee302, which takes the whole pipeline down with it — Web Build, Web Deploy, all three Desktop builds and the Production Release Gate every one skipped. Nothing from that run can ship.

18:1  error  `components/weekly-rotation` import should occur after import of `components/page/Page`   import/order
27:1  error  `components/weekly-rotation` import should occur after import of `components/tabs`        import/order
25:1  error  `components/weekly-rotation` import should occur after import of `components/nav/mobile/NavContext`  import/order
✖ 4 problems (3 errors, 1 warning)

Cause

#14582 renamed components/discover-weeklycomponents/weekly-rotation in place. d sorts before header/lineup/nav/page/tabs; w sorts after all of them, so the import line that was correctly placed under the old name is now out of order under the new one. Three call sites were affected.

Fix

Moved each WeeklyRotationBanner import to its new alphabetical position. Import-only change — no runtime difference, and --fix produces exactly this.

  • pages/feed-page/components/desktop/FeedPageContent.tsx
  • pages/search-explore-page/components/desktop/SearchExplorePage.tsx
  • pages/search-explore-page/components/mobile/SearchExplorePage.tsx

Test plan

  • All three files' components/ import blocks verified in sorted order
  • CI lint green (the real check — this is the job that was failing)

Note

This is currently what blocks the production web deploy. The Production gate has five runs waiting back to Aug 24, including the 12/31/69 album-date fix (#14579); main HEAD couldn't join them because of this lint failure.

🤖 Generated with Claude Code

The Weekly Rotation rename (#14582) renamed `components/discover-weekly` to
`components/weekly-rotation` in place, which moved it past its neighbours
alphabetically and broke `import/order` in three files. Lint failed on main,
so the Web Build, Deploy, Desktop and Production Release Gate jobs all
skipped — nothing from that run could ship.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1a85995

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers
dylanjeffers merged commit d12d919 into main Sep 1, 2026
17 checks passed
@dylanjeffers
dylanjeffers deleted the fix/weekly-rotation-import-order branch September 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant