Skip to content

[fix] Raise the Mooncake minimum version to 0.3.13 - #219

Merged
0oshowero0 merged 1 commit into
mainfrom
fix/mooncake-put-timeout
Nov 20, 2026
Merged

0oshowero0 merged 1 commit into
mainfrom
fix/mooncake-put-timeout

Conversation

@0oshowero0

Copy link
Copy Markdown
Collaborator

Background

Older Mooncake versions could return success from batch_upsert_from() after a transfer timed out. TransferQueue would then skip retries and mark the data ready. Mooncake 0.3.13 reports the failure for the affected key so TransferQueue can retry the write. [Upstream change](kvcache-ai/Mooncake#2683)

Require Mooncake >=0.3.13 for both the mooncake extra and the non-CUDA package used in CI.

This PR fixes #218. Great thanks @chenjr97 for reporting the issue and tracing it to Mooncake’s batch upsert finalization.

Validation

Built the TransferQueue wheel, verified the dependency in its metadata, and passed Python compilation and CI install command syntax checks. The full pytest suite and Mooncake integration tests are pending CI because the local environment lacks the test dependencies.

Mooncake 0.3.13 reports timed-out batch upserts as failures so the existing TransferQueue retry logic can handle them. Apply the same minimum to the non-CUDA build used in CI.

Signed-off-by: Codex <codex@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T03:11:24.479876Z e5dd40b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@0oshowero0
0oshowero0 merged commit 8c87197 into main Nov 20, 2026
10 checks passed
@0oshowero0
0oshowero0 deleted the fix/mooncake-put-timeout branch November 20, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Mooncakeclient]: Mooncake transfer timeout is treated as a successful put

1 participant