Repository navigation
[fix] Raise the Mooncake minimum version to 0.3.13 - #219
Merged
Merged
Conversation
Mooncake 0.3.13 reports timed-out batch upserts as failures so the existing TransferQueue retry logic can handle them. Apply the same minimum to the non-CUDA build used in CI. Signed-off-by: Codex <codex@openai.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Older Mooncake versions could return success from
batch_upsert_from()after a transfer timed out. TransferQueue would then skip retries and mark the data ready. Mooncake 0.3.13 reports the failure for the affected key so TransferQueue can retry the write. [Upstream change](kvcache-ai/Mooncake#2683)Require Mooncake
>=0.3.13for both themooncakeextra and the non-CUDA package used in CI.This PR fixes #218. Great thanks @chenjr97 for reporting the issue and tracing it to Mooncake’s batch upsert finalization.
Validation
Built the TransferQueue wheel, verified the dependency in its metadata, and passed Python compilation and CI install command syntax checks. The full pytest suite and Mooncake integration tests are pending CI because the local environment lacks the test dependencies.