Repository navigation
Avoid retaining PostgreSQL query results and prepared plans - #87
Merged
Araq merged 3 commits intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ormin currently calls
PQpreparefor every query invocation with a fresh name and retains each named plan for the lifetime of the PostgreSQL connection. It also retains thePGresultfromPQprepare, and failed query results can escape cleanup. On long-lived connections this caused PostgreSQL backend memory to grow without bound.Use
PQexecParamsto preserve bound parameters without persistent named plans. Clear failedPGresultvalues before raising while preserving the database error. Add PostgreSQL regression coverage for repeated parameterized and command queries, failure recovery, and error messages.Tested in debug and release against PostgreSQL. The prior implementation accumulated 1,000 named plans in the repeated-query test.