Repository navigation
Conversation
Naming and permission are now separate. The exposure table still decides which selectors JS may call; the name comes from the method the object runs for a selector: at: key put: value <jsName: 'atPut'> is called as atPut(key, value), and without the pragma the PharoJS-style name stays (at_put_). The name is looked up on the method actually run, so an inherited pragma applies and an override without one falls back. Two exposed selectors with one name signal a QJSError before anything is registered. A pragma alone exposes nothing. QJSBinding computes the names; QJSContext>>jsNameOf: is gone. The lookup costs about 114 ns per selector (pharo-a). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming and permission are now separate. The exposure table still decides which selectors JS may call; the name comes from the method the object runs for a selector: at: key put: value <jsName: 'atPut'> is called as atPut(key, value), and without the pragma the PharoJS-style name stays (at_put_). The name is looked up on the method actually run, so an inherited pragma applies and an override without one falls back. Two exposed selectors with one name signal a QJSError before anything is registered. A pragma alone exposes nothing.
QJSBinding computes the names; QJSContext>>jsNameOf: is gone. The lookup costs about 114 ns per selector (pharo-a).