Repository navigation
Build against an installed QuickJS instead of carrying its source - #6
Merged
Merged
Conversation
The repository no longer holds QuickJS as submodules. QuickJS is built with its own build, as it comes from its repository: quickjs-ng with cmake, Bellard's with make, both static and position independent. The shim's Makefile takes QUICKJS_PREFIX and links the static library into libqjsshim, so the one library carries the QuickJS its header describes; without a static one it links the shared library (Homebrew's quickjs-ng). The interrupt handler takes a plain pointer as its first argument, so the shim fits QuickJS versions passing the runtime and those passing the context. The CI builds QuickJS first (quickjs-ng v0.17.0, Bellard 84e723f) and then the shim against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository no longer holds QuickJS as submodules. QuickJS is built with its own build, as it comes from its repository: quickjs-ng with cmake, Bellard's with make, both static and position independent. The shim's Makefile takes QUICKJS_PREFIX and links the static library into libqjsshim, so the one library carries the QuickJS its header describes; without a static one it links the shared library (Homebrew's quickjs-ng).
The interrupt handler takes a plain pointer as its first argument, so the shim fits QuickJS versions passing the runtime and those passing the context. The CI builds QuickJS first (quickjs-ng v0.17.0, Bellard 84e723f) and then the shim against it.