Skip to content

refactor: Renamed methods and dataclasses - #113

Merged
ShrimpCryptid merged 10 commits into
mainfrom
refactor/rename-methods-classes
Sep 16, 2026
Merged

ShrimpCryptid merged 10 commits into
mainfrom
refactor/rename-methods-classes

Conversation

@ShrimpCryptid

@ShrimpCryptid ShrimpCryptid commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Renamed methods and classes to remove references to "Colorizer", in line with the new repo + package rename. Backwards-compatibility was kept with old methods and class names, with deprecation warnings.

Once this and #112 are merged, I'll cut a new major release (v2.0.0) for the project.

Estimated review size: small, 15 minutes

Solution

  • Renamed convert_colorizer_data() to convert_tfe_data().
  • Renamed ColorizerMetadata to DatasetMetadata.
  • Renamed ColorizerDatasetWriter to TfeDatasetWriter.
  • Added backwards-compatibility with existing methods + classes.
  • Added migration guide from v1 to v2.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Keyfiles (delete if not relevant):

  1. tfe_data/converter.py
  2. tfe_data/types.py
  3. documentation/MIGRATION.md

@ShrimpCryptid ShrimpCryptid added documentation Improvements or additions to documentation internals labels Sep 14, 2026
@ShrimpCryptid
ShrimpCryptid added this pull request to stack #114 September 14, 2026 18:58
@ShrimpCryptid ShrimpCryptid changed the title Refactor/rename methods classes refactor: Renamed methods and dataclasses Sep 14, 2026
@ShrimpCryptid
ShrimpCryptid force-pushed the refactor/rename-methods-classes branch from 05e11bc to 5ce0e84 Compare September 14, 2026 19:04
@ShrimpCryptid ShrimpCryptid self-assigned this Sep 14, 2026
@ShrimpCryptid
ShrimpCryptid force-pushed the refactor/rename-methods-classes branch from 5ba8d76 to c759f78 Compare September 14, 2026 19:12
@ShrimpCryptid
ShrimpCryptid requested a balanced review from Copilot September 14, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Undeclared runtime dependencies, broken legacy deserialization, and invalid documentation references undermine the intended compatibility migration.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Aligns public APIs and documentation with the renamed TFE package while retaining deprecated compatibility aliases.

Changes:

  • Renames converter, metadata, and writer APIs.
  • Adds deprecated legacy wrappers and aliases.
  • Updates tests, examples, and migration documentation.
File summaries
File Description
tfe_data/writer.py Renames the dataset writer and adds its legacy alias.
tfe_data/utils.py Updates metadata type references.
tfe_data/types.py Renames dataset metadata and adds its legacy alias.
tfe_data/converter.py Renames conversion APIs and adds a compatibility wrapper.
tests/test_writer.py Migrates writer tests to new names.
tests/test_types.py Migrates metadata tests.
tests/test_converter.py Migrates converter tests.
README.md Updates the conversion example.
documentation/MIGRATION.md Adds v1-to-v2 migration instructions.
documentation/getting_started_guide/GETTING_STARTED.ipynb Updates tutorial API references.
documentation/DATA_FORMAT.md Updates writer and metadata examples.
documentation/bin/example_scripts/getting_started_guide.py Updates example imports and calls.
documentation/bin/example_scripts/check_conversion_api.py Updates the conversion check script.
Review details
  • Files reviewed: 11/13 changed files
  • Comments generated: 4
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tfe_data/types.py
Comment thread tfe_data/types.py Outdated
Comment thread documentation/getting_started_guide/GETTING_STARTED.ipynb Outdated
Comment thread tfe_data/converter.py
@ShrimpCryptid
ShrimpCryptid force-pushed the refactor/rename-methods-classes branch 2 times, most recently from f6e0f06 to 03a3b86 Compare September 14, 2026 20:57
@ShrimpCryptid
ShrimpCryptid marked this pull request as ready for review September 14, 2026 21:04
Base automatically changed from refactor/update-docs to main September 16, 2026 18:35
@ShrimpCryptid
ShrimpCryptid force-pushed the refactor/rename-methods-classes branch from 03a3b86 to 1f57bb8 Compare September 16, 2026 18:35
@ShrimpCryptid
ShrimpCryptid merged commit 3911f3f into main Sep 16, 2026
1 check passed
@ShrimpCryptid
ShrimpCryptid deleted the refactor/rename-methods-classes branch September 16, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update links + documentation with new tfe-data name

4 participants