Skip to content

DPL Analysis: Fix DECLARE_SOA_CCDB_COLUMN_FULL's default construcor w… - #15679

Open
mhemmer-cern wants to merge 1 commit into
AliceO2Group:devfrom
mhemmer-cern:fix-ccdb-column
Open

DPL Analysis: Fix DECLARE_SOA_CCDB_COLUMN_FULL's default construcor w…#15679
mhemmer-cern wants to merge 1 commit into
AliceO2Group:devfrom
mhemmer-cern:fix-ccdb-column

Conversation

@mhemmer-cern

@mhemmer-cern mhemmer-cern commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

…hich was firing cppcoreguidelines-pro-type-member-init in O2Physics code when used.
The concrete error was: Constructor does not initialize these bases: Column

…hich was firing `cppcoreguidelines-pro-type-member-init` in O2Physics code when used
@mhemmer-cern
mhemmer-cern requested a review from a team as a code owner August 14, 2026 08:54
@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

This got triggered when the clang-tidy settings in O2Physics got changed: AliceO2Group/O2Physics#16868

@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

Hello @ktf @aalkin ,
Could you have a look at this please?

@ktf

ktf commented Aug 15, 2026

Copy link
Copy Markdown
Member

Isn't this an issue with the linter?

@mhemmer-cern

Copy link
Copy Markdown
Contributor Author

I mean yeah sure it was clang-tidy that stated the issue. From my understanding this way Column is not left not initialize. I don't know if the default constructor is an actual problem that needs fixing, but if it silents the linter, shouldn't it be fine?

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for fa1c4f9 at 2026-08-23 04:56:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/84c439494635148dd2bb59ed75e4f57fdfde24e0/slc9_x86-64/o2checkcode/1.0-local444/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='googlebenchmark ninja-fortran date safe_int defaults-release alibuild-recipe-tools json-c bz2 CMake ninja Python-modules-list O2-customization Alice-GRID-Utils UUID double-conversion FairCMakeModules pytorch_cpuinfo MPFR'
+ echo 'FULL_BUILD_REQUIRES=googlebenchmark ninja-fortran date safe_int defaults-release alibuild-recipe-tools json-c bz2 CMake ninja Python-modules-list O2-customization Alice-GRID-Utils UUID double-conversion FairCMakeModules pytorch_cpuinfo MPFR'
FULL_BUILD_REQUIRES=googlebenchmark ninja-fortran date safe_int defaults-release alibuild-recipe-tools json-c bz2 CMake ninja Python-modules-list O2-customization Alice-GRID-Utils UUID double-conversion FairCMakeModules pytorch_cpuinfo MPFR
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 14
+ REVISION_VALUE=14
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ '[' -z 14 ']'
+ echo 'googlebenchmark ninja-fortran date safe_int defaults-release alibuild-recipe-tools json-c bz2 CMake ninja Python-modules-list O2-customization Alice-GRID-Utils UUID double-conversion FairCMakeModules pytorch_cpuinfo MPFR'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants