[6853] fix(frontend): Invoke registry skills by their name, not their slug - #6910
Conversation
The / palette inserted a registry skill's workflow slug, which carries a random suffix (skill-name-23ad). The runner installs the skill under its SKILL.md name, which the embed entry already stores as a sibling name. skillCommandName now prefers that name and falls back to the slug only when the slug is itself a valid skill name, so nameless built-in entries (the retired getting-started stub in old revisions) get no row. Closes #6853
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds and exports ChangesSkill command name resolution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Skills without a valid command name are hidden from the slash-command palette, so no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
Updated at 2026-09-17T13:37:03.852Z |
Context
Typing
/in the agent chat composer lists the agent's skills, but a registry skill showed up as/skill-name-23adinstead of/skill-name. The menu used the skill's registry slug, which carries a random suffix to keep workflows unique. The runner installs the skill under its own SKILL.mdname, so the suffixed command never matched what the agent knows.Changes
A new helper,
skillCommandName, picks the command for each skill row. The embed entry already stores the skill's name next to the reference, so the helper uses that.Before:
/legacy-inline-skill-18a1. After:/legacy-inline-skill.If an entry has no valid name, the helper falls back to the slug, but only when the slug is itself shaped like a skill name. Built-in slugs (
__ag__…, the older_agenta.…) never are. The only built-in entries saved without a name point at the retired getting-started stub in old revisions, so those rows are now hidden instead of showing a slug nobody should type.No backend change. Registry slugs stay as they are.
Tests / notes
itemDescriptors.test.tscover followed and pinned registry skills, the slug fallback, nameless and named built-ins, and inline skills./magainst the EE dev stack: an agent withlegacy-inline-skill(sluglegacy-inline-skill-18a1) showed and inserted the suffixed slug before the change and/legacy-inline-skillafter. Its other four skills were unchanged.What to QA
/. The Skills section shows/<skill name>with no suffix, and Enter inserts that same text.