session: wait for both parts to start before landing them in the park test - #1676
Merged
Merged
Conversation
… test TestAParentHandedADivisionBeforeItStartedOpensOnTheReportsAndNotOnTheWait counted the parts the test's runner had seen right after the parent parked. A part reaches that runner on a goroutine of its own, and the parent parks on the parts it has outstanding, not on their runners having started, so on a loaded CI box the park came first and the test read one part (#1674's gate on fc7feb0). It now waits for both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestAParentHandedADivisionBeforeItStartedOpensOnTheReportsAndNotOnTheWaitturned #1674'stouched packagesgate red onfc7feb003with1 parts were admitted, want the two that were proposed. It passed on re-run.Cause. The test counts the parts its runner has seen right after the parent parks. A part reaches that runner on a goroutine of its own (
TaskGraph.runFrontier), and the parent parks on the parts it has outstanding, not on their runners having started. So on a loaded box the park can come first.Fix. Wait (bounded,
waitFor) for both parts to start before landing them. Test-only; no product code changes.Proof.
-cpu=1,2,8.🤖 Generated with Claude Code