Repository navigation
Fix MODIFY COLUMN parsing when the data type is omitted - #338
Merged
git-hulk merged 1 commit intoOct 28, 2026
Merged
Conversation
git-hulk
changed the title
ALTER TABLE ... MODIFY COLUMN can reject valid modifier-only changes or store a modifier as the column type. Modifier keywords are treated as type names when the declaration omits its data type. For example, CODEC(LZ4) is stored in Column.Type instead of Column.Codec, while a leading COMMENT causes parsing to fail. This bug predates AfterShip#337. Recognize COMMENT, CODEC and TTL as modifiers when the type is omitted, preserving their AST fields through formatting and reparsing. Preserve explicit-type parsing and duplicate-modifier rejection, and regenerate the AST and formatting fixtures for the affected ALTER statements. Assistant-By GPT-6
git-hulk
force-pushed
the
codex/fix-modify-column-modifiers
branch
from
October 28, 2026 03:57
365e9e2 to
dfd4d76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE ... MODIFY COLUMN can reject valid modifier-only changes or
store a modifier as the column type. Modifier keywords are treated as
type names when the declaration omits its data type.
For example, CODEC(LZ4) is stored in Column.Type instead of Column.Codec,
while a leading COMMENT causes parsing to fail. This bug predates #337.
Recognize COMMENT, CODEC and TTL as modifiers when the type is omitted,
preserving their AST fields through formatting and reparsing. Preserve
explicit-type parsing and duplicate-modifier rejection, and regenerate
the AST and formatting fixtures for the affected ALTER statements.
Assistant-By GPT-6