Rounding out specification of prune behavior inside lean model - #152
Merged
Merged
Conversation
Bench A/B vs base: donejob log · 2026-10-04 01:52:43 UTC base b4a6abd → head 85220b4, 3 round(s), median of each run averaged; negative is faster
20 case(s) moved more than 5%
Full tables per bench are in the job log and the bench-out artifact. |
luketpeterson
marked this pull request as ready for review
October 3, 2026 06:40
imlvts
approved these changes
Oct 3, 2026
imlvts
left a comment
Collaborator
There was a problem hiding this comment.
My criteria are the following:
- The model covers more
- The model is simpler (fewer special cases)
As far as I can tell this PR covers that. Simpler model, covers more.
Please upload reproducer corpus files
corpus/prune{-flag-remove-val.bin,-remove-val-valued.bin,-unmasked.bin,-subtract.bin}
and we can merge
…ope for this PR. This PR was intended to update the lean model with a model of the correct behavior of the prune flag and the prune operations. Including reproduction cases was incidental and incomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.