Skip to content

Fix/prefix zipper missing source - #147

Merged
luketpeterson merged 3 commits into
Adam-Vandervorst:masterfrom
imlvts:fix/prefix-zipper-missing-source
Oct 2, 2026
Merged

luketpeterson merged 3 commits into
Adam-Vandervorst:masterfrom
imlvts:fix/prefix-zipper-missing-source

Conversation

@imlvts

@imlvts imlvts commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Fix PrefixZipper over a source rooted at a missing path
The prefix always reported itself as existing, with one child, so a walk
descended through it into a source that doesn't exist. The prefix now
exists only when the source's root does.

Fix PrefixZipper fork rooted at the focus

The prefix always reported itself as existing, with one child, so a walk
descended through it into a source that doesn't exist. The prefix now
exists only when the source's root does.
@luketpeterson

Copy link
Copy Markdown
Collaborator

The off_root change to make fork_read_zipper work feels like the wrong fix. I think this becomes a non-issue if we address #96 I'm rolling back that change.

The rest look good.

@luketpeterson
luketpeterson merged commit a047212 into Adam-Vandervorst:master Oct 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants