Fix exclusive zippers rooted at an emptied link - #146
Merged
luketpeterson merged 2 commits intoOct 2, 2026
Merged
luketpeterson merged 2 commits into
luketpeterson merged 2 commits into
Conversation
prepare_cf returned an existing link even when it was the empty sentinel, left by remove_branches, take_map or grafting nothing. A write zipper rooted there couldn't move or read. Give it a fresh node, as for a missing link.
…ned appropriately
Collaborator
|
Good fix. I added one defensive test, but the implementation was already correct. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare_cf returned an existing link even when it was the empty sentinel, left by remove_branches, take_map or grafting nothing. A write zipper rooted there couldn't move or read. Give it a fresh node, as for a missing link.