Fix/trie ref long node key and empty is shared - #145
Merged
luketpeterson merged 4 commits intoOct 2, 2026
Merged
luketpeterson merged 4 commits into
luketpeterson merged 4 commits into
Conversation
new_with_key_and_path_in copied the focus's node key into a fixed stack buffer, overflowing it (UB in release) when the key was longer, and truncated key + path when the two together didn't fit. No child key is longer than a node key, so only the first MAX_NODE_KEY_BYTES bytes of the combined key can decide a step: look up that prefix, and keep stepping through a child that begins within the node key. A combined key too long to remain at a node is invalid.
Collaborator
|
Good fixes. I added some optimizations on top. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TrieRef lookups with a node key longer than its buffer
new_with_key_and_path_in copied the focus's node key into a fixed stack
buffer, overflowing it (UB in release) when the key was longer, and
truncated key + path when the two together didn't fit. No child key is
longer than a node key, so only the first MAX_NODE_KEY_BYTES bytes of the
combined key can decide a step: look up that prefix, and keep stepping
through a child that begins within the node key. A combined key too long
to remain at a node is invalid.
(similar to Luke's 203b7d5))
Fix TrieRef::is_shared on an empty node