Repository navigation
Fix Studio's AdaMCP tool metadata dependency - #199
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio's build, test and run tools use Metadata and Tool._meta, which are absent from the previous AdaMCP revision. Pin both the editor package and Windows dependency preparation to ed7bb9076f9f8c91e2584ca9b7201df0e03defb1, merged in AdaEngine/AdaMCP#1, and update the lockfile.
Validated on Windows with Swift 6.3.1: the AdaEditorPackageTests product builds successfully, including AdaEditor.exe; all five tests in EditorAgentMCPConnectionTests and EditorAgentFrameCaptureTests pass, covering connection sharing, restored/new HTTP and stdio sessions, bridge responses/errors and frame-wait cancellation. Four protocol tests against production AdaMCP sources and four Windows staging tests also pass. Preparation of the newly pinned Windows package succeeds.