Calibration - #1107
Draft
dhensle wants to merge 92 commits into
Draft
Conversation
…nto calibration
plus some bug fixes including in RNG and odds ratio
also fixing some bugs captured by AI review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new automated calibration workflow for ActivitySim, modularizing calibration logic into a dedicated package and integrating it into the main simulation runner. The changes include the addition of a comprehensive calibration package, updates to the CLI to support calibration runs and output preservation, and enhancements to model settings validation to include calibration configuration.
Calibration package introduction and integration:
activitysim.core.calibrationpackage, splitting calibration logic into focused modules such asorchestrator.py,settings.py,component.py, and more, with a clear public API. [1] [2] [3]activitysim/cli/run.pyto import and utilize the calibration package, including logic to determine when to preserve outputs and to run the calibration workflow before standard or multiprocess simulation. [1] [2] [3]Settings and validation improvements:
settings_checker.pyto explicitly validate the optionalcalibration.yamlconfiguration file using the same error aggregation as other settings. [1] [2]Random number generator and reproducibility:
initialize_households, ensured that bothhouseholdsandpersonsdataframes are registered as random number generator channels to support reproducible calibration and simulation.Documentation:
README.mdfor the calibration package, describing its architecture, configuration, iteration/recovery semantics, and integration with the main workflow.