USB serial state interface: DSP-authoritative ACK, display watchdog, STATUS/LEVEL/HELP - #4
Closed
xmutantson wants to merge 2 commits into
Closed
xmutantson wants to merge 2 commits into
xmutantson wants to merge 2 commits into
Conversation
Apply the parsed channel mode to the live DSP for every serial SIM parameter-page command (not only WGN-MPD): assign intMode and force reinitialization. Bound BUSY CH1 IN to the nine-element fltLogs table; apply MULTIPATHS, OFFSET and FM-deviation routing immediately; restore fade rate, FM rate and FM amplitude from EEPROM into the DSP at boot; reject empty and non-numeric parameters before the setters coerce them to zero; correct the FM-rate display multiplier (10 * fltLogs). Updates the regression tests for both sketches.
…L/HELP) Echo the live DSP state after each command, ending in OK or ERROR, as the single source of truth. Add a one-way DSP-to-display watchdog with change detection and a 30-second repaint. Add STATUS (mode and S:N), LEVEL (input level in mVp-p) and HELP (command and range listing ending END HELP). Legacy OK and ? replies preserved. With the watchdog now owning the display, remove the redundant ParseSetParameter parser. Based on the PR ARSFI#2 branch (apply after PR ARSFI#2).
xmutantson
force-pushed
the
feat/usb-state-interface
branch
from
September 13, 2026 20:08
61112c1 to
90793f3
Compare
Author
|
Superseded by the consolidated correctness PR #5. The replacement incorporates the STATUS/LEVEL/HELP and state-interface work, corrects the ancillary-command profile-replacement regression, moves acknowledgment after DSP application, and adds sequence-level and state-truthfulness coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional USB serial state interface on top of the existing command set. It is independent of the serial-mode bug fixes (PR #2) and preserves the legacy
OK/?replies.What it adds
OKorERROR. The DSP is the single source of truth; the reply is not a blind echo of the request, so a command that fails to take effect reportsERROR.?) — prints the command list with valid ranges, terminated byEND HELP.Scope
Behavior/feature only. No serial-mode bug fixes, no MPG-header change, no RESET/CODECINIT. Based directly on
master.Verification
On an unamended
master, the ACK will correctly surface a mode-selection mismatch asERROR; once PR #2's fixes are merged, the same interface confirms the corrected state asOK.