Repository navigation
refactor(web): a calmer modal and Settings page - #84
Merged
Merged
Conversation
…size, and the text never scales
…aller radius and a softer shadow
… account forms in windows
… sits behind an info icon
… when something different is missing
…ads late no longer overflows it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal and the Settings page were busier than they needed to be. This follows how elastic-ui draws them (its
DECISIONS.md: no blur, text never scales, fewer boxes) and how Kolmi lays out Settings.Modal (
components/ui/Modal.tsx, used by 10 dialogs; its props don't change)Settings
Textarea's label is now tied to its field, asInput's already was.I tested it against the real app: while the window opens, the box goes from 192×93 to 512×394 with
transform: nonethe whole way, and the box and the panel have the same height once a late-loading list arrives.Not covered: the close animation and reduced motion were checked in tests, not by eye. The Appearance box and the learner's Settings page keep their old look.
Web: 1054 tests pass, lint and typecheck are clean. The only red check is
test_llm_client.py::test_a_model_whose_thinking_is_opt_in_is_left_alone, which fails the same way onmainanddevelop.