Repository navigation
Enforce minimum hrx commit when building with HRX_SOURCE_DIR - #126
Merged
Merged
Conversation
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
AaronStGeorge
changed the title
HRX_SOURCE_DIR
AaronStGeorge
added a commit
to AaronStGeorge/ws-template
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When using the existing
HRX_SOURCE_DIRmechanism to build hrx as part of llama.cpp enforce that hrx is at least at the commit listed inhrx-minimum-commit.txt.Motivation
This change is motivated by a recent experience with #119. Before a certain hrx commit the change caused numerical regression and fixed one after, as there was no mechanism to keep agents and humans aware of the new hrx requirement the change caused some thrash. Now we have this mechanism that thrash should be avoidable in future.