Repository navigation
ggml-hrx: work around private RoPE helper merge ordering - #120
Closed
AaronStGeorge wants to merge 1 commit into
Closed
AaronStGeorge wants to merge 1 commit into
AaronStGeorge wants to merge 1 commit into
Conversation
Work around the private-helper merge order issue tracked in ROCm/hrx-system#1089. Assisted-by: Codex
AaronStGeorge
marked this pull request as ready for review
September 28, 2026 23:59
Collaborator
Author
|
Merged as part of #121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Llama 3.2 3B decode fails to produce perplexity because Loom cannot resolve
@ggml_rope_f32_pair_packet(HRX issue #1089). This PR temporarily works around the linker ordering bug; kernel arithmetic is unchanged. Moverope_f32.loomafterllm_attention_qkv_matmul_postops.loomin the vector Q/K recipes, keepinglibrary_sourcesandcompile_dependenciesaligned.CI evidence
Both completed runs cover all 25 smoke models, prefill and decode, on HRX/Vulkan gfx1151. The baseline already includes #119's IQ4 fix, so this pair isolates the ordering workaround.
682337098905cf69ea4b8ec00bc50a9993bd6ff812aa79f6b822998f2dc48cba97218e916e9f7869The three missing decode measurements (Llama 3.2 1B, Llama 3.2 3B and SmolLM3 3B) all report the unresolved helper before and pass afterward. All previously available HRX PPL values are unchanged. Both workflows are red because expected failures now XPASS; the after run passes all 50 numerical comparisons.
Selected model:
Llama-3.2-3B-Instruct-UD-Q4_K_XL.gguf.Complete before/after comparison: all 25 smoke models, both regimes
Smoke comparison: before / after.
Both automation trees differ only in the llama.cpp gitlink and use HRX
c9ffcd25e74ff3580cb128a485c74f0c3d48fec4with the same unfiltered model manifest. The baseline source tree is identical to integration merge4e14145b37c11f5e9394e02868e81d6edae7cce3. Build checkouts and raw PPL logs were verified.Settings:
model_tier=smoke,skip_benchmarks=["lemonade-benchmark"]; WikiText-2, context/batch 512; prefill microbatch 512 with 32 chunks; decode microbatch 1 with two chunks; unchanged HRX/Vulkan PPL ratio limit 1.10. Different gfx1151 runners were used. Both exact Q/K recipes also reproduce the before/after link result locally on gfx1100.Stability: ten additional Llama 1B/8B runs passed all 40 comparisons across nine runners with identical PPL. The earlier high-PPL/NaN results were likely runner/environment related; the original runner was not retested.
Requirements