Repository navigation
Shell decision: own CSS, no vendored theme (D59) (#137) - #146
Merged
Merged
Conversation
The landing page and stages/default/ of the own-CSS and the vendored-Hextra variant, at 1280 and 390 px, light and dark, built from tests/fixtures/site-data/rulebook.json. The criteria table and the choice follow in the README of this folder with ADR D59. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ADR D59 records the owner's choice after the spike: the site shell stays own CSS, confirming D31's "no theme" and D35's rejected vendored theme with the spike's evidence. docs/dashboard.md section 3 names the decision; the spike record under docs/reference/spikes/wp16-shell/ carries the question, the two scratch branches, the criteria table, the sixteen screenshots and the notes for the shell PR; the ADR index, the spike index and the beta.8 release notes gain their lines. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 28, 2026
…class count restated (#137) D59 now quotes D31's real sentence and D35's real rejected alternative, says both stand unchanged and that a theme vendored into site/ is a further alternative rejected here; the hx: count is 132 distinct in our layouts (156 with the vendored toggle partial); the implementation details carry "as built on the scratch branch". The spike record names the head commits of the scratch branches, the icons in use, the local Hugo version, and moves the uncovered points to a "Not covered" section. dashboard.md section 3 says the shell will be own CSS; the spike index keeps listing the WP01 spikes only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
4 tasks
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137.
The site shell (header, dark mode, mobile menu, footer, design tokens) stays own CSS. The owner chose it after the spike built the landing page and
stages/default/twice; the result comment with the criteria table and the 16 screenshots is #137 (comment).Spike result
resources.GetRemoteis left (I removed the remote-icon branch ofutils/icon.html). The build runs offline, the output has no CDN reference, it needs 12 files, and the 628-row matrix needs no fight with the theme CSS.rulebook.json. Its menu script throws without a sidebar. Its footer is built around the theme credit. Its head and scripts fingerprint the asset paths. What we kept was the compiled CSS and a theme toggle.hx:classes). Hextra's dark mode needs JavaScript, so without it the site stays light even on a dark system.site/themes/hextra/(main.cssis 144,984 B) to every organization repository and to the D35 compare. Each Hextra release means repeating three trims:icon.html,icons.yaml, and leaving outtheme.toml. Copied as is,theme.toml(blob/main/) andicons.yaml("v1") break the Deploy forbidden-literal test. Own CSS adds no file underthemes/; itssite.cssis 15,881 B.Scratch branches (never merged)
wp16/spike-own-css: the shell PR WP16: design system and app shell (tokens, logo, header, dark mode, mobile, sticky matrix, favicon, Open Graph, footer) #138 starts from it; delete it once WP16: design system and app shell (tokens, logo, header, dark mode, mobile, sticky matrix, favicon, Open Graph, footer) #138 has taken what it needs.wp16/spike-hextra: delete it after this PR merges.The plan put both variants on one branch; I used two so each can be checked out and built as it is.
Files
docs/adr/0059-the-site-shell-is-own-css-and-no-vendored-theme.md: the new ADR D59. It confirms D31 and D35, which stand unchanged, and rejects a theme vendored intosite/as a further alternative; Hugo Book was not built, because no constraint failed. It also notes the D58/D59 renumbering.docs/adr/README.md: index row and reference line.docs/dashboard.mdsection 3: one paragraph naming the decision.docs/reference/spikes/wp16-shell/README.md: the spike record (question, method, criteria table, screenshots, answer, notes for WP16: design system and app shell (tokens, logo, header, dark mode, mobile, sticky matrix, favicon, Open Graph, footer) #138), plus the 16 PNGs (40 to 133 KB each).docs/reference/spikes/README.md, which indexes the WP01 spikes)RELEASENOTES.md: one line under## v1.0.0-beta.8.Nothing under
template/changes.Tests
Invoke-Pester -Path ./tests/Docs.Tests.ps1 -Output Normal, withRULEBOOK_DOCS_PATHset to the template docs: 340 passed, 0 failed, 0 skipped (again after review round 1).template/sitefinds no hit, and the CDN grep of both builds is empty.🤖 Generated with Claude Code