Skip to content

Pl mg - #69

Open
poli-machines wants to merge 7 commits into
mainfrom
pl_mg
Open

poli-machines wants to merge 7 commits into
mainfrom
pl_mg

Conversation

@poli-machines

Copy link
Copy Markdown
Collaborator
  • added deleting magnets
  • creating new motion setup (to insert magnets into the band)
  • created own run_mag

@poli-machines
poli-machines requested a review from sadda October 15, 2026 11:28
@sadda

sadda commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

@poli-machines Please do the following:

  • Write a proper description of the PR. I need to understand from the description what the PR does. Check the PRs of Haitao.
  • Give me some basic results from running the run_mag.py file, including the designs. We should have a function plotting the designs in Geometry, if not, write it please. If it exists, but does not include plotting magnets, add it.
  • I guess there are some bugs (delete_magnets is never called) and inefficiencies (set_magnets is called twice). Give the code more care.
  • Add a safety check that the magnets are not sticking out of the barriers.
  • Do I understand correctly that add_rotor_magnet (from an older PR) modifies the magnets? If so, this should not be so. It is supposed to just place the materials there. Or am I missing something?

@poli-machines

Copy link
Copy Markdown
Collaborator Author

@sadda
This PR:

  • plot_barrier is modified to draw not only the barriers but magnets too if they are available
  • reassign_motion_setup is created to refresh existing motion_setup. It helps magnets to appear inside of the Band for correct calculation. It works like this: checking if motion_setup exits - if yes, delete it and creating new one and putting magnets inside of it.
  • delete_magnets were moved inside of delete_rotor and now magnets are deleted with rotor after calculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants