Skip to content

63 parameterize assign stator coils in 3f 36s and 5f 40s machines - #64

Merged
sadda merged 14 commits into
mainfrom
63-parameterize-assign_stator_coils-in-3f_36s-and-5f_40s-machines
Oct 2, 2026
Merged

sadda merged 14 commits into
mainfrom
63-parameterize-assign_stator_coils-in-3f_36s-and-5f_40s-machines

Conversation

@haitao-ZCU

Copy link
Copy Markdown
Collaborator
  • add general methods ( assign_phase_windings, compute_post_params,) to ComputationBase and parameterize coils
  • move set_solution_expressions, set_output_vars, set_post_params to ComputationBase
  • use loops and parameterizations to write phase_currents ( original I_A, I_B, I_C,...) instead of hardcoding
  • simplify 3f_60s and 5f_60s
  • all tests passed

@haitao-ZCU haitao-ZCU linked an issue Oct 2, 2026 that may be closed by this pull request
@sadda

sadda commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

@haitao-ZCU I guess that the methods compute_solution_expressions and compute_post_params can be removed as well and their content moved to set_* methods.

@haitao-ZCU

Copy link
Copy Markdown
Collaborator Author

@sadda
Agreed. I have moved their contents to set_ functions and all tests passed.

@sadda
sadda merged commit 9503c5b into main Oct 2, 2026
6 checks passed
@haitao-ZCU
haitao-ZCU deleted the 63-parameterize-assign_stator_coils-in-3f_36s-and-5f_40s-machines branch October 12, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameterize assign_stator_coils in 3f_36s and 5f_40s machines

2 participants