Repository navigation
56 extract proper units from ansys - #58
Merged
Merged
Conversation
haitao-ZCU
commented
Sep 30, 2026
Collaborator
- currently, we use solutions.data_real(expr, convert_to_SI=True) to extract the values from Ansys, this can help us obtain the correct vars quickly instead of manually hard-coding and guessing unit scaling factors (a big mess).
- corresponding tests are also updated, and all passed, including test_ansys_regression_synrm_5f_40s.py.
Collaborator
|
Good, that makes it much simpler. I would add something like to |
Collaborator
|
Also, this duplicates #54, which should be closed. |
Collaborator
Author
|
@sadda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.