Repository navigation
Add automatic check for Ansys reserved variable names in ComputationBase - #34
Merged
Merged
Conversation
Collaborator
|
@haitao-ZCU Is there a reason why the checks are performed only for |
…omputationBase and GeometryBase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an automatic check in ComputationBase that raises a ValueError if any key in oper_params or output_vars matches one of Ansys's reserved intrinsic variable names (see https://ansyshelp.ansys.com/public/Views/Secured/Electronics/v242/en/Subsystems/Maxwell/Content/UsingIntrinsicVariables.htm), which is exactly the class of bug found in #30 (f colliding with Ansys's own F).
tests/test_computation.py covers this with four cases: