Repository navigation
Replace f with w in motor1's oper_params and excitation formulas - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #30, this PR removes the remaining use of f in motor1 (synrm_3f_36s.py):
matching what Replace design variable f with w to avoid Ansys intrinsic variable co… #30 already did for motor2.
Verified no impact on results: ran the old (f based) and new (w based) excitation formulas side by side for motor1 across 3 structures (a total of 60 points), comparing TorAvg and TorRippleRms. The results are same.
The calculated results are attached.
IA_IB_IC_old_vs_new_motor1.csv