Skip to content

Fixed Geometry2 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadda merged 1 commit into from
Sep 3, 2026
Merged

Fixed Geometry2 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions motors/motor2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ def set_winds_params(self):
super().set_winds_params()
self.wind_params["Nc"] = "113"

def set_derived_params(self):
pass


class Computation2(ComputationBase):
def set_oper_params(self):
Expand Down
7 changes: 3 additions & 4 deletions tests/test_design2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@ def test_oper_params_fully_replaced(computation2):
}


def test_derived_params_are_not_set(geometry2):
# Geometry2.set_derived_params() is a no-op, unlike Geometry's.
assert not hasattr(geometry2, "rotor_r_min")
assert not hasattr(geometry2, "rotor_r_max")
def test_derived_params_are_set(geometry2):
assert hasattr(geometry2, "rotor_r_min")
assert hasattr(geometry2, "rotor_r_max")


def test_solution_expressions_is_a_list_ending_in_torque(computation2):
Expand Down
Loading