Repository navigation
feat(reader): add native uniform and Zipf traces - #347
Open
blackdragoon26 wants to merge 1 commit into
Open
blackdragoon26 wants to merge 1 commit into
blackdragoon26 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds native uniform and bounded Zipf workloads through the
syntrace type, following #135.Generation uses O(1) state per reader, including clones. Requests have unit size and unset timestamps. Reset and independent clones reproduce the same workload through the existing reader and simulation APIs.
Also includes the CLI sampler cleanup covered in #346, needed for leak-free sampling.
Type of change
How was it tested?
All 11 CTest targets pass on macOS Debug and Ubuntu Release with LeakSanitizer. The dedicated reader tests also pass with AddressSanitizer and UndefinedBehaviorSanitizer.
Coverage includes distribution checks, input validation, reset/clone behavior, navigation, sampling, request limits, and serial/parallel replay.
ctest --test-dir _build_dbg --output-on-failure --parallel 4passes-Wall -Wextra -Werror)The Ubuntu strict-warning build passes. macOS reports an existing warning in the debug executable.
Results
Native and materialized traces produce identical request and miss counts for LRU, FIFO and S3FIFO, including parallel runs and warmup.
Checklist
clang-format(or the pre-commit hook fromscripts/setup_hooks.sh)