Skip to content

openssl3-replace-default.patch: inverted error returns and DSO handle leak in load_wolfprov_and_init() #379

Description

@taytayallday

Two bugs in patches/openssl3-replace-default.patch (wolfProvider v1.1.1), in the
load_wolfprov_and_init() function patched into crypto/provider_predefined.c:

Bug 1 — Inverted error return values

OSSL_provider_init_fn must return 1 on success, 0 on failure
(ref).

All three error paths (DSO_new() failure, DSO_load() failure, DSO_bind_func() failure)
incorrectly return 1, causing OpenSSL to treat a failed provider load as success.

Bug 2 — Global static DSO *d leaked on repeated calls

Both "default" and "fips" provider entries call load_wolfprov_and_init(). On the
second call, d is non-NULL but the function unconditionally calls DSO_new(), overwriting
the previous handle and leaking it.

Suggested fix

  • Change all error-path returns from return 1 to return 0.
  • Guard DSO_new() / DSO_load() with if (!d) so the handle is allocated once and reused.
  • Reset d = NULL after DSO_free(d) on DSO_load failure so a retry is possible.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions