From 693a9c8ed97a859b98a26f5653f6dda14e6068dc Mon Sep 17 00:00:00 2001 From: Gabriel Paradiso Date: Thu, 10 Sep 2026 11:32:29 +0200 Subject: [PATCH] fix: Execution Errors in More than F nodes not alerting on user errors --- http_action/common/metrics.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/http_action/common/metrics.go b/http_action/common/metrics.go index a5f0b0b88..36fe2f86d 100644 --- a/http_action/common/metrics.go +++ b/http_action/common/metrics.go @@ -172,8 +172,11 @@ func (m *Metrics) IncrementExecutionError(ctx context.Context, proxyMode ProxyMo } func (m *Metrics) IncrementExecutionTimeout(ctx context.Context, proxyMode ProxyMode, lggr logger.Logger) { + // NOTE: timeouts are user errors (the user's configured request Timeout expired, or the + // external endpoint was too slow for it). They are tracked separately via + // http_action_execution_timeout_count and must NOT be counted as execution errors, + // otherwise the "Execution Errors in More than F nodes" alert fires on user errors. m.executionTimeout.Add(ctx, 1, metric.WithAttributes(attribute.String(AttrProxyMode, proxyMode.String()))) - m.executionError.Add(ctx, 1, metric.WithAttributes(attribute.String(AttrProxyMode, proxyMode.String()))) } func (m *Metrics) IncrementExternalEndpointError(ctx context.Context, proxyMode ProxyMode, lggr logger.Logger) {