Skip to content

Commit fcc4368

Browse files
razor-xclaude
andauthored
fix: Validate every paginated request like the original request (#1009)
* fix: Validate every paginated request like the original request The paginator rebuilt each page request with only the pathname, method, response key, and data, dropping the request parameters and validation configuration, so required parameter checks were skipped for every paginated fetch including the first page. A cursor was also dropped entirely when the original request had no params or body. Build each page through a new SeamHttpRequest.withPageCursor, which copies the entire request configuration and merges the page cursor into the params or body chosen by the request method. New configuration fields now travel to page requests automatically instead of being hand-copied in the paginator. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2 * Apply suggestion from @razor-x * docs: Trim the withPageCursor doc Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8xeJm2Hd923k8uo6eoFd2 --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent fb10143 commit fcc4368

48 files changed

Lines changed: 119 additions & 78 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎codegen/layouts/partials/route-class-methods.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ static fromPersonalAccessToken(
100100
createPaginator<const TResponse, const TResponseKey extends keyof TResponse>(
101101
request: SeamPaginatedRequest<TResponse, TResponseKey>,
102102
): SeamPaginator<TResponse, TResponseKey> {
103-
return new SeamPaginator<TResponse, TResponseKey>(this, request)
103+
return new SeamPaginator<TResponse, TResponseKey>(request)
104104
}
105105

106106
async updateClientSessionToken(

‎src/lib/routes/access-codes/access-codes.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-codes/simulate/simulate.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-codes/unmanaged/unmanaged.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-grants/access-grants.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-grants/unmanaged/unmanaged.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-methods/access-methods.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/access-methods/unmanaged/unmanaged.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/acs/access-groups/access-groups.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/lib/routes/acs/acs.ts‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)