diff --git a/README.md b/README.md index 53a2868..d26e9cc 100644 --- a/README.md +++ b/README.md @@ -349,7 +349,10 @@ retry window. `--use-contact-time-zone` reads the schedule's windows in the cont `--retry-window-minutes` is how long Reply keeps trying to send once the send is due, 1 to 4320 minutes (Reply's default is 90); a number outside that is refused before any call (`usage.range`). Reply takes the time zone only with `--schedule-id` and the retry window only for a send made -later, and answers them otherwise with `reply.invalid_request`. +later, and answers them otherwise with `reply.invalid_request`. A Reply that knows direct sends but +not yet the LinkedIn scheduler answers `--schedule-id` or `--use-contact-time-zone` on a LinkedIn +send with `errors[]` naming the field (`reply.invalid_request`), and one that knows neither sends at +once, as without them. Reply refuses a send it cannot time when it takes it, and nothing is sent. A `--schedule-id` naming no schedule this account can read is `schedule.not_found`, a schedule with no active day diff --git a/src/__tests__/operations/commands.test.ts b/src/__tests__/operations/commands.test.ts index 6852ce3..90b879f 100644 --- a/src/__tests__/operations/commands.test.ts +++ b/src/__tests__/operations/commands.test.ts @@ -313,7 +313,8 @@ describe('operations/commands', ()=>{ expect(flat, text).toContain('status "sent" means Reply took the send; state, when Reply gives it, says whether it has gone ' + 'out: queued, waitingForSchedule or sending is not yet, then sent, failed or cancelled'); expect(flat, text).toContain('direct-send get reads it later, and direct-send cancel stops one not yet sent'); - // Every send takes a schedule and its time zone; only the LinkedIn sends take a retry window and map the refusals. + // Every send takes a schedule and its time zone, and maps the refusals of a send Reply cannot time; only the LinkedIn + // sends take a retry window. const linkedin = name !== 'send-email'; expect(flat, text).toContain('A send timed by --schedule-id may answer state waitingForSchedule'); expect(flat, text).toContain('send_after is then left out, and estimated_send_at is when Reply expects to send it.'); @@ -327,8 +328,11 @@ describe('operations/commands', ()=>{ expect(flat.includes('--retry-window-minutes is how long Reply keeps trying to send it once it is due, 1 to 4320 ' + 'minutes (Reply\'s default is 90); one outside that is refused before any call (usage.range)'), text).toBe(linkedin); expect(flat.includes('Reply takes it only with --schedule-id or --send-after'), text).toBe(linkedin); - // A Reply without the scheduler ignores both on a LinkedIn send and sends at once; no refusal stands for it. - expect(flat, text).not.toContain('before its scheduler'); + // A Reply with direct sends but not yet the LinkedIn scheduler refuses the schedule's fields on a LinkedIn send, naming + // the field; one with neither ignores them and sends at once. Only the LinkedIn sends say so. + expect(flat.includes('A Reply that knows direct sends but not yet the LinkedIn scheduler answers --schedule-id or ' + + '--use-contact-time-zone on a LinkedIn send with errors[] naming the field (reply.invalid_request), and one that knows ' + + 'neither sends at once, as without them.'), text).toBe(linkedin); // A send Reply cannot time is refused under the same three codes on every route. expect(flat, text).toContain('schedule.not_found is a --schedule-id naming no schedule this account can read, schedule.no_slot a ' + 'schedule with no active day that has a time range, so it never opens, and contact.time_zone_missing a contact without the time zone ' diff --git a/src/operations/commands.ts b/src/operations/commands.ts index b28d421..3c09c0a 100644 --- a/src/operations/commands.ts +++ b/src/operations/commands.ts @@ -350,10 +350,12 @@ const SCHEDULED = 'A send timed by --schedule-id may answer state waitingForSche // The codes of a send Reply cannot time, the same on every route. const SCHEDULE_CODES = ['schedule.not_found', 'schedule.no_slot', 'contact.time_zone_missing']; -// The retry window only a LinkedIn send takes. +// The retry window only a LinkedIn send takes, and what a Reply before the LinkedIn scheduler does with the schedule. const LINKEDIN_SCHEDULED = '--retry-window-minutes is how long Reply keeps trying to send it once it is due, 1 to 4320\n' + 'minutes (Reply\'s default is 90); one outside that is refused before any call (usage.range). Reply takes it only with\n' - + '--schedule-id or --send-after, and answers it otherwise with errors[] (reply.invalid_request).\n'; + + '--schedule-id or --send-after, and answers it otherwise with errors[] (reply.invalid_request). A Reply that knows\n' + + 'direct sends but not yet the LinkedIn scheduler answers --schedule-id or --use-contact-time-zone on a LinkedIn send\n' + + 'with errors[] naming the field (reply.invalid_request), and one that knows neither sends at once, as without them.\n'; time_zone_options(later_options(add_contact_options(contact_command.command('send-email'), true) .option('--email-account-id ', 'The mailbox to send from (see `account list`)')