Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

CPU usage reduction suggestion for the DnsCache View Plugin #69

Description

@DavidXanatos

In the DnsCache View Plugin in the main.cpp function TraverseDnsCacheTable,
for every entry obtained with DnsGetCacheDataTable_I
the function loops through all types deemed interesting defined in the typeList array,
this seams very inefficient as according to S2017 cpu profiler DnsQuery causes quite a significant CPU load.
instead of looping through all types for each entry, why not just check tablePtr->Type, if its one of the interesting types and than call only DnsQuery(tablePtr->Name, tablePtr->Type, ...)
That would save a lot of CPU cycles.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions