From e540f17ec2e09526f551f7e7a6f46b2123de9126 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <323649642+oc-tmueller@users.noreply.github.com> Date: Tue, 27 Oct 2026 11:30:12 +0100 Subject: [PATCH] ci: keep the Docker Hub link check off core's feature links MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Docker Hub description job runs markdown-link-check over every Markdown file. The expected-failures headers had a made-up example link, and core's lint-expected-failures.sh requires each entry to link to core's master branch, where 10.16-only features such as cliDbConversion/dbConversion.feature do not exist. Put the example in inline code, mark the 10.16-only entry, and skip core feature links in mlc_config.json. The lint only checks the form of those links; what catches a stale entry is run.sh's unexpected-pass check. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com> --- .github/acceptance/expected-failures-10.16.6-full.md | 4 +++- .github/acceptance/expected-failures-10.16.6-smoke.md | 4 +++- .github/acceptance/expected-failures-11.0.1-full.md | 2 +- .github/acceptance/expected-failures-11.0.1-smoke.md | 2 +- agents.md | 1 + mlc_config.json | 7 +++++++ 6 files changed, 16 insertions(+), 4 deletions(-) create mode 100644 mlc_config.json diff --git a/.github/acceptance/expected-failures-10.16.6-full.md b/.github/acceptance/expected-failures-10.16.6-full.md index 034117c..485a03f 100644 --- a/.github/acceptance/expected-failures-10.16.6-full.md +++ b/.github/acceptance/expected-failures-10.16.6-full.md @@ -1,11 +1,13 @@ # Scenarios of ownCloud core 10.16.6's acceptance tests that are expected to fail against this # image (full run). run.sh fails the job on any other failure, and on a listed # scenario that passes. One entry per line, as in core's own lists: -# - [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12) +# `- [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12)` ## CLI # Found in this repository's CI; they depend on how the image is set up. +# 10.16-only: this feature is gone from core's master, so its master link is a 404; +# the scenario is in the v10.16.6 tag. - [cliDbConversion/dbConversion.feature:30](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliDbConversion/dbConversion.feature#L30) - [cliMain/configKey.feature:81](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliMain/configKey.feature#L81) - [cliManageApps/appsPath.feature:18](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliManageApps/appsPath.feature#L18) diff --git a/.github/acceptance/expected-failures-10.16.6-smoke.md b/.github/acceptance/expected-failures-10.16.6-smoke.md index 1051f13..9690352 100644 --- a/.github/acceptance/expected-failures-10.16.6-smoke.md +++ b/.github/acceptance/expected-failures-10.16.6-smoke.md @@ -1,11 +1,13 @@ # Scenarios of ownCloud core 10.16.6's acceptance tests that are expected to fail against this # image (smoke run). run.sh fails the job on any other failure, and on a listed # scenario that passes. One entry per line, as in core's own lists: -# - [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12) +# `- [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12)` ## CLI # Found in this repository's CI; they depend on how the image is set up. +# 10.16-only: this feature is gone from core's master, so its master link is a 404; +# the scenario is in the v10.16.6 tag. - [cliDbConversion/dbConversion.feature:30](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliDbConversion/dbConversion.feature#L30) - [cliMain/configKey.feature:81](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliMain/configKey.feature#L81) - [cliManageApps/appsPath.feature:18](https://github.com/owncloud/core/blob/master/tests/acceptance/features/cliManageApps/appsPath.feature#L18) diff --git a/.github/acceptance/expected-failures-11.0.1-full.md b/.github/acceptance/expected-failures-11.0.1-full.md index 3ba5e8a..cf3b403 100644 --- a/.github/acceptance/expected-failures-11.0.1-full.md +++ b/.github/acceptance/expected-failures-11.0.1-full.md @@ -1,7 +1,7 @@ # Scenarios of ownCloud core 11.0.1's acceptance tests that are expected to fail against this # image (full run). run.sh fails the job on any other failure, and on a listed # scenario that passes. One entry per line, as in core's own lists: -# - [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12) +# `- [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12)` ## CLI diff --git a/.github/acceptance/expected-failures-11.0.1-smoke.md b/.github/acceptance/expected-failures-11.0.1-smoke.md index bf09d3a..20bd661 100644 --- a/.github/acceptance/expected-failures-11.0.1-smoke.md +++ b/.github/acceptance/expected-failures-11.0.1-smoke.md @@ -1,7 +1,7 @@ # Scenarios of ownCloud core 11.0.1's acceptance tests that are expected to fail against this # image (smoke run). run.sh fails the job on any other failure, and on a listed # scenario that passes. One entry per line, as in core's own lists: -# - [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12) +# `- [apiSuite/file.feature:12](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiSuite/file.feature#L12)` ## CLI diff --git a/agents.md b/agents.md index 18b2285..9f0a5ab 100644 --- a/agents.md +++ b/agents.md @@ -29,6 +29,7 @@ GitHub Actions. - `.github/dependabot.yml` — weekly GitHub Actions dependency updates - `.renovaterc.json` — Renovate preset for Docker digest updates - `.editorconfig` — formatting rules (2-space indent, LF, trailing newline) +- `mlc_config.json` — markdown-link-check config for the Docker Hub description job; skips links to core's acceptance feature files, which `lint-expected-failures.sh` requires to point at core's master - `CHANGELOG.md` — flat, date-based changelog at repo root - `LICENSE` — MIT diff --git a/mlc_config.json b/mlc_config.json new file mode 100644 index 0000000..a4c8370 --- /dev/null +++ b/mlc_config.json @@ -0,0 +1,7 @@ +{ + "ignorePatterns": [ + { + "pattern": "^https://github\\.com/owncloud/core/blob/master/tests/acceptance/features/" + } + ] +}