Spring 4.0 support

[hauner]

https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-7.0-Release-Notes

The interesting part seems to be

https://docs.spring.io/spring-framework/reference/7.0-SNAPSHOT/web/webmvc/mvc-controller/ann-requestmapping.html#mvc-ann-requestmapping-version

The question is how to provide the possible versions, OpenAPI does not support that (yet...)

OAI/sig-lifecycle#6
OAI/sig-moonwalk#82

[tedberg]

Is there a setting to generate with Jackson 3 instead of Jackson 2? I see in the commit messages that you are using Spring 7, but I don't see how to generate compatible code.

[hauner]

There is currently no specific Spring Boot 4 code. The Spring 7 stuff is only used in the tests (dependabot pull request).

Still on Spring Boot 3 here. My Spring Boot 4 samples just use jackson 2 so I didn't think about that....

To switch between 2/3 it should provide another option like

options:
  jackson: com.fasterxml.jackson
#  jackson: tools.jackson

or

options:
  jackson: 2
#  jackson: 3

I did the first version for bean-validation , javax vs jakarta but I wonder if I go just for the simpler configuration. May be more user friendly to just switch between 2and 3.

[tedberg]

The second options would be simpler. Someone could have a typo in the first option. That first option also implies that if Jackson 4 launches and a package prefix of com.jackson4 that we could just supply that. Using 2 or 3, someone could put 4, but the mapping parser can easily return an error that only 2 and 3 are supported in this version.

[hauner]

Yes, thought so too and I started to implement it like that.

[hauner]

I'm confused now ;-)

Do you have something that does not work?

With Jackson 3 it seems that it is still using the annotations in the com.fasterxml.jackson.annotation namespace. This means, at least for now, it should just work out of the box ....

[tedberg]

For Jackson 3, they changed the package from com.fasterxml.jackson to tools.jackson. https://cowtowncoder.medium.com/jackson-3-0-0-ga-released-1f669cda529a

So if you upgrade to Spring Boot 4 and don't change the config back to using Jackson 2, none of the generated code compiles. The only workaround is to downgrade back to Jackson 2.

[hauner]

https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md#2-new-maven-group-id-and-java-package

This states that the annotation package does not change.

And annotation is the only package the processor adds to the generated code... if i didn't miss anything :-)

[tedberg]

Oh, that's actually good news - I must have been missing a maven dependency during the trial upgrade. Will try again.

[tedberg]

Ok, I can confirm, I was able to upgrade an app using openapi-processor to Spring Boot 4.0.4 without issue. I guess the title for this issue can be more specifically about the API Versioning you mentioned.

[tedberg]

The other minor thing I see is that the generated code in the spring folder use deprecated annotations, causing compiler warnings.

[hauner]

Can you tell me which one? Taking a quick look at the output of the samples I don't see any.