From b4a937d50cb5b86c19bfb554cee2e0372e47205c Mon Sep 17 00:00:00 2001 From: Simon Schrottner Date: Wed, 14 Oct 2026 18:35:24 +0200 Subject: [PATCH] fix(flagd): make FlagdThreadFactory final for SpotBugs 4.10 SpotBugs 4.10 reports CT_CONSTRUCTOR_THROW for the null check in the constructor. The class is package-private and never subclassed, so making it final removes the finalizer-attack surface the check is about. Signed-off-by: Simon Schrottner --- .../openfeature/contrib/providers/flagd/FlagdThreadFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactory.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactory.java index 54b54c7195..3b41093af8 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactory.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactory.java @@ -7,7 +7,7 @@ /** * Thread factory for the Flagd provider to allow named daemon threads to be created. */ -class FlagdThreadFactory implements ThreadFactory { +final class FlagdThreadFactory implements ThreadFactory { private final AtomicInteger counter = new AtomicInteger(); private final String namePrefix;