Fix path-only Python project manager defaults

Assisted-by: OpenAI Codex

Author: atomiechen

src/features/settings/settingHelpers.ts

@@ -41,7 +41,7 @@ export function isDefaultEnvManagerBroken(): boolean {
 export function getDefaultEnvManagerSetting(wm: PythonProjectManager, scope?: Uri): string {
     const config = workspaceApis.getConfiguration('python-envs', scope);
     const settings = getSettings(wm, config, scope);
-    if (settings && settings.envManager.length > 0) {
+    if (settings?.envManager) {
         return settings.envManager;
     }
     // Only show the warning once per session
@@ -69,7 +69,7 @@ export function getDefaultPkgManagerSetting(
     const config = workspaceApis.getConfiguration('python-envs', scope);
 
     const settings = getSettings(wm, config, scope);
-    if (settings && settings.packageManager.length > 0) {
+    if (settings?.packageManager) {
         return settings.packageManager;
     }
 

src/internal.api.ts

@@ -424,8 +424,8 @@ export interface PythonProjectManager extends Disposable {
 
 export interface PythonProjectSettings {
     path: string;
-    envManager: string;
-    packageManager: string;
+    envManager?: string;
+    packageManager?: string;
     workspace?: string;
 }
 

src/test/features/settings/settingHelpers.unit.test.ts

@@ -9,12 +9,14 @@ import * as sender from '../../../common/telemetry/sender';
 import * as workspaceApis from '../../../common/workspace.apis';
 import {
     addPythonProjectSetting,
+    getDefaultEnvManagerSetting,
+    getDefaultPkgManagerSetting,
     migrateGlobalDefaultEnvManagerSetting,
     setAllManagerSettings,
     setEnvironmentManager,
     setPackageManager,
 } from '../../../features/settings/settingHelpers';
-import { PythonProjectsImpl } from '../../../internal.api';
+import { PythonProjectManager, PythonProjectsImpl } from '../../../internal.api';
 import { MockWorkspaceConfiguration } from '../../mocks/mockWorkspaceConfig';
 
 /**
@@ -25,6 +27,55 @@ function getTestWorkspacePath(): string {
     return process.platform === 'win32' ? 'C:\\workspace' : '/workspace';
 }
 
+suite('Setting Helpers - Optional Project Managers', () => {
+    const VENV_MANAGER_ID = 'ms-python.python:venv';
+    const PIP_MANAGER_ID = 'ms-python.python:pip';
+    const workspacePath = getTestWorkspacePath();
+    const workspaceUri = Uri.file(workspacePath);
+    const projectUri = Uri.joinPath(workspaceUri, 'backend');
+    const workspaceFolder: WorkspaceFolder = {
+        uri: workspaceUri,
+        name: 'workspace',
+        index: 0,
+    };
+    const project = {
+        name: 'backend',
+        uri: projectUri,
+    };
+    const projectManager = {
+        get: (uri: Uri) => (uri.fsPath === projectUri.fsPath ? project : undefined),
+    } as unknown as PythonProjectManager;
+
+    teardown(() => {
+        sinon.restore();
+    });
+
+    function createPathOnlyProjectConfig(): MockWorkspaceConfiguration {
+        const mockConfig = new MockWorkspaceConfiguration();
+        (mockConfig as any).get = <T>(key: string, defaultValue?: T): T | undefined => {
+            if (key === 'pythonProjects') {
+                return [{ path: 'backend' }] as T;
+            }
+            if (key === 'defaultEnvManager') {
+                return VENV_MANAGER_ID as T;
+            }
+            if (key === 'defaultPackageManager') {
+                return PIP_MANAGER_ID as T;
+            }
+            return defaultValue;
+        };
+        return mockConfig;
+    }
+
+    test('uses default managers when a pythonProjects entry only specifies path', () => {
+        sinon.stub(workspaceApis, 'getConfiguration').returns(createPathOnlyProjectConfig());
+        sinon.stub(workspaceApis, 'getWorkspaceFolder').returns(workspaceFolder);
+
+        assert.strictEqual(getDefaultEnvManagerSetting(projectManager, projectUri), VENV_MANAGER_ID);
+        assert.strictEqual(getDefaultPkgManagerSetting(projectManager, projectUri), PIP_MANAGER_ID);
+    });
+});
+
 /**
  * These tests verify that manager edits without a project do not write settings
  * and are logged explicitly as ignored global edits.