From f3f06acb5712b60ce64f16bee8176d8a0ef07228 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 22 Oct 2026 14:02:55 -0700 Subject: [PATCH] Report workspace/diagnostic as the failed request in workspace pulls The error handler for workspace diagnostic pulls passed DocumentDiagnosticRequest.type to handleFailedRequest. A failed pull was therefore logged and shown as "Request textDocument/diagnostic failed." Pass WorkspaceDiagnosticRequest.type so the log and notification name the request that was actually sent. --- client/src/common/diagnostic.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/common/diagnostic.ts b/client/src/common/diagnostic.ts index 92429105b..653064df4 100644 --- a/client/src/common/diagnostic.ts +++ b/client/src/common/diagnostic.ts @@ -649,7 +649,7 @@ class DiagnosticRequestor implements Disposable { resultReporter(converted); return { items: [] }; }, (error) => { - return this.client.handleFailedRequest(DocumentDiagnosticRequest.type, token, error, { items: [] }); + return this.client.handleFailedRequest(WorkspaceDiagnosticRequest.type, token, error, { items: [] }); }).finally(() => { // Runs on success, cancellation, request failure, and a convertReport throw. disposable.dispose();