The new check for ExcludeAssets="compile" is fine, but the error message shouldn't tell the user to set PrivateAssets="all" when in fact only PrivateAssets="runtime" is required, since that can introduce build breaks in referencing packages/projects due to a missing reference assembly to msbuild packages.
|
Text="A PackageReference to the package '%(_DistinctMSBuildPackagesReferencedPoorly.NuGetPackageId)' at version '%(_DistinctMSBuildPackagesReferencedPoorly.NuGetPackageVersion)' is present in this project without ExcludeAssets="runtime" and PrivateAssets="all" set. This can cause errors at run-time due to MSBuild assembly-loading." |
The new check for
ExcludeAssets="compile"is fine, but the error message shouldn't tell the user to setPrivateAssets="all"when in fact onlyPrivateAssets="runtime"is required, since that can introduce build breaks in referencing packages/projects due to a missing reference assembly to msbuild packages.MSBuildLocator/src/MSBuildLocator/build/Microsoft.Build.Locator.targets
Line 22 in 44b8f1e