Skip to content

[Bug] .set and .mset works not correctly with cache-manager v5 #4

Description

@Sadzurami

cache-manager v5 changed ttl from milliseconds to seconds.

So, if we works with cache-manager v5, we already use ms by default.
But here under the hood mset multiply provided ttl by 1000.

const ttl = (options.ttl || this.#default_ttl) * 1000

Suggestion: drop multiplying, add cache-manager v5+ to peer-deeps and increase major version of package.

upd: looks like cache-manager v5 changed a lot since v4, at least they not use callbacks anymore, so requires a bit more work for update current package.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions