fix(tests): ignore private CSI sequences in terminal frames

Author: qorzj

packages/cli/src/tests/compact-command.test.ts

@@ -6,7 +6,7 @@ import { syncBuiltinESMExports } from "node:module";
 import { PassThrough, Writable } from "node:stream";
 import { test, type TestContext } from "node:test";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import React from "react";
 import { render } from "ink";
 import { SessionManager, type SessionEntry, type SessionMessage } from "@vegamo/deepcode-core";
@@ -75,7 +75,7 @@ async function harness(t: TestContext, compact: (signal: AbortSignal) => Promise
   const output = Object.assign(
     new Writable({
       write(chunk, _encoding, callback) {
-        const frame = stripVTControlCharacters(chunk.toString());
+        const frame = stripTerminalControls(chunk.toString());
         if (frame.trim()) frames.push(frame);
         callback();
       },

packages/cli/src/tests/permission-prompt.test.ts

@@ -5,7 +5,7 @@ import React, { useState } from "react";
 import { render, Text } from "ink";
 import { PassThrough, Writable } from "node:stream";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import type { AskPermissionRequest } from "@vegamo/deepcode-core";
 
 test("getScopeRiskColor maps permission scopes by risk", () => {
@@ -34,7 +34,7 @@ async function prompt(t: TestContext, requests: AskPermissionRequest[], planMode
   const stdout = Object.assign(
     new Writable({
       write(chunk, _encoding, done) {
-        const text = stripVTControlCharacters(chunk.toString());
+        const text = stripTerminalControls(chunk.toString());
         if (text.trim()) frame = text;
         done();
       },

packages/cli/src/tests/process-output.test.ts

@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import { PassThrough, Writable } from "node:stream";
 import { test, type TestContext } from "node:test";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import React from "react";
 import { Box, render } from "ink";
 import stringWidth from "string-width";
@@ -70,7 +70,7 @@ test("output tabs align to eight columns with wide characters and ANSI colors",
 test("wrapped output preserves Unicode, blank lines, indentation and ANSI styles", () => {
   const text = "中文👩‍💻".repeat(8);
   const lines = wrapProcessOutputLines(`\u001b[31m${text}\u001b[0m\n\n  end`, 12);
-  assert.equal(lines.slice(0, -2).map(stripVTControlCharacters).join(""), text);
+  assert.equal(lines.slice(0, -2).map(stripTerminalControls).join(""), text);
   assert.deepEqual(lines.slice(-2), ["", "  end"]);
   assert.ok(lines.every((line) => stringWidth(line) <= 12));
   assert.ok(lines[1].startsWith("\u001b[31m"));
@@ -82,7 +82,7 @@ async function terminal(t: TestContext, element: React.ReactElement) {
   const stdout = Object.assign(
     new Writable({
       write(chunk, _encoding, done) {
-        const text = stripVTControlCharacters(chunk.toString());
+        const text = stripTerminalControls(chunk.toString());
         if (text.trim()) frame = text;
         done();
       },

packages/cli/src/tests/raw-mode.test.ts

@@ -6,7 +6,7 @@ import { syncBuiltinESMExports } from "node:module";
 import { PassThrough, Writable } from "node:stream";
 import { test, type TestContext } from "node:test";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import React from "react";
 import { render } from "ink";
 import { SessionManager } from "@vegamo/deepcode-core";
@@ -31,7 +31,7 @@ async function harness(t: TestContext, config?: string) {
   const output = Object.assign(
     new Writable({
       write(chunk, _encoding, callback) {
-        const frame = stripVTControlCharacters(chunk.toString());
+        const frame = stripTerminalControls(chunk.toString());
         if (frame.trim()) frames.push(frame);
         callback();
       },

packages/cli/src/tests/status-line-render.test.ts

@@ -2,7 +2,7 @@ import assert from "node:assert/strict";
 import { Writable } from "node:stream";
 import { test } from "node:test";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import React from "react";
 import { render } from "ink";
 import stringWidth from "string-width";
@@ -13,7 +13,7 @@ test("model status stays on one physical line while the spinner updates and the
   const output = Object.assign(
     new Writable({
       write(chunk, _encoding, callback) {
-        const frame = stripVTControlCharacters(chunk.toString()).trimEnd();
+        const frame = stripTerminalControls(chunk.toString()).trimEnd();
         if (frame) frames.push(frame);
         callback();
       },

packages/cli/src/tests/terminal-helper.ts

@@ -1,7 +1,7 @@
 import type { TestContext } from "node:test";
 import { PassThrough, Writable } from "node:stream";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import type React from "react";
 import { render } from "ink";
 
@@ -12,7 +12,7 @@ export async function terminal(t: TestContext, element: React.ReactElement, colu
   const stdout = Object.assign(
     new Writable({
       write(chunk, _encoding, done) {
-        const text = stripVTControlCharacters(chunk.toString());
+        const text = stripTerminalControls(chunk.toString());
         if (text.trim()) {
           frame = text;
           rawFrame = chunk.toString();

packages/cli/src/tests/terminal-output.test.ts

@@ -0,0 +1,14 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+import { stripTerminalControls } from "./terminal-output";
+
+test("keyboard mode changes do not become visible terminal frames", () => {
+  for (const control of ["\u001b[>4;1m", "\u001b[>4;0m", "\u001b[?1004h", "\u001b[?2004l"]) {
+    assert.equal(stripTerminalControls(control), "");
+  }
+});
+
+test("terminal output retains prompt text while removing styling and mode changes", () => {
+  const output = "\u001b[>4;1m\u001b[90m> Type your message...\u001b[0m\n4;1m\u001b[>4;0m";
+  assert.equal(stripTerminalControls(output), "> Type your message...\n4;1m");
+});

packages/cli/src/tests/terminal-output.ts

@@ -0,0 +1,7 @@
+import { stripVTControlCharacters } from "node:util";
+
+export function stripTerminalControls(value: string): string {
+  // Node's ANSI stripper leaves text behind for private CSI parameters,
+  // including the modifyOtherKeys sequences emitted by the prompt input.
+  return stripVTControlCharacters(value.replace(/\u001b\[[0-?]*[ -/]*[@-~]/g, ""));
+}

packages/cli/src/tests/undo-draft.test.ts

@@ -6,7 +6,7 @@ import { syncBuiltinESMExports } from "node:module";
 import { PassThrough, Writable } from "node:stream";
 import { test, type TestContext } from "node:test";
 import { setTimeout } from "node:timers/promises";
-import { stripVTControlCharacters } from "node:util";
+import { stripTerminalControls } from "./terminal-output";
 import React from "react";
 import { render } from "ink";
 import {
@@ -109,7 +109,7 @@ async function harness(t: TestContext, imageUrls: string[] = []) {
   const output = Object.assign(
     new Writable({
       write(chunk, _encoding, callback) {
-        const frame = stripVTControlCharacters(chunk.toString());
+        const frame = stripTerminalControls(chunk.toString());
         if (frame.trim()) frames.push(frame);
         callback();
       },